[ 
https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Zhuge updated HDFS-12318:
------------------------------
    Attachment: HDFS-12318.002.patch

Thanks for the unit test!

+1 LGTM with minor comments:
* Rename unit test from {{testopenInfo}} to {{testOpenInfo}}, upper case "O"
* Wait for the minicluster to become active by calling {{cluster.waitActive()}}
* Make sure the cluster is always shut down upon exception
* Make sure input stream {{fin}} is always closed upon exception, using 
try-with-resource

Since these changes are simple, I took the liberty to upload patch 002 with the 
changes, hope you don't mind.

> Fix IOException condition for openInfo in DFSInputStream
> --------------------------------------------------------
>
>                 Key: HDFS-12318
>                 URL: https://issues.apache.org/jira/browse/HDFS-12318
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0-beta1
>            Reporter: legend
>            Assignee: legend
>         Attachments: HDFS-12318.001.patch, HDFS-12318.002.patch, 
> HDFS-12318.patch
>
>
> when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, 
> "openInfo" successfully obtains the last blcok locations, and the function 
> still throws IOException.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to