[
https://issues.apache.org/jira/browse/HDFS-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136462#comment-16136462
]
Xiao Chen commented on HDFS-10899:
----------------------------------
bq. It looks like ReencryptionTask.batch does not need to use file name as the
key; instead, it can use INode id as key, and this way it reduces the overhead
to translate inode to file name back and forth.
Yup, I think that's inline with Daryn's comment.
bq. ReencryptionUpdater#processOneTask ... better part of ReencryptionTask
instead of ReencryptionUpdater...
Intention was that handler produces callables, and updater consumes callables.
{{ReencryptionTask}} is a struct holding information about the callable, so I
think process on updater makes sense.
bq. Does task.numFilesUpdated equal task.batch.size()?
May or may not. If things caused a file to be skipped (those conditions above
which would lead to a {{continue}}), then not equal.
bq. This variable name is a little cryptic: zst
Renamed to 'tracker', better name suggestion welcome.
bq. There are a few TODOs
Failure handling wasn't done at the time. patch 15 does it, with added unit
tests that utilize fault injector.
> Add functionality to re-encrypt EDEKs
> -------------------------------------
>
> Key: HDFS-10899
> URL: https://issues.apache.org/jira/browse/HDFS-10899
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: encryption, kms
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: editsStored, HDFS-10899.01.patch, HDFS-10899.02.patch,
> HDFS-10899.03.patch, HDFS-10899.04.patch, HDFS-10899.05.patch,
> HDFS-10899.06.patch, HDFS-10899.07.patch, HDFS-10899.08.patch,
> HDFS-10899.09.patch, HDFS-10899.10.patch, HDFS-10899.10.wip.patch,
> HDFS-10899.11.patch, HDFS-10899.12.patch, HDFS-10899.13.patch,
> HDFS-10899.14.patch, HDFS-10899.wip.2.patch, HDFS-10899.wip.patch, Re-encrypt
> edek design doc.pdf, Re-encrypt edek design doc V2.pdf
>
>
> Currently when an encryption zone (EZ) key is rotated, it only takes effect
> on new EDEKs. We should provide a way to re-encrypt EDEKs after the EZ key
> rotation, for improved security.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
