[ https://issues.apache.org/jira/browse/HDFS-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138089#comment-16138089 ]
Wellington Chevreuil commented on HDFS-12336: --------------------------------------------- I believe these test failures are not related. Had reviewed related code changes, it shouldn't affect these tests, and same tests are passing locally: {noformat} Running org.apache.hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.833 sec - in org.apache.hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy Results : Tests run: 5, Failures: 0, Errors: 0, Skipped: 0 {noformat} {noformat} Running org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.811 sec - in org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics Results : Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 {noformat} {noformat} Running org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 61.527 sec - in org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Results : Tests run: 14, Failures: 0, Errors: 0, Skipped: 0 {noformat} > Listing encryption zones still fails when deleted EZ is not a direct child of > snapshottable directory > ----------------------------------------------------------------------------------------------------- > > Key: HDFS-12336 > URL: https://issues.apache.org/jira/browse/HDFS-12336 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 3.0.0-alpha4 > Reporter: Wellington Chevreuil > Assignee: Wellington Chevreuil > Priority: Minor > Attachments: HDFS-12336.001.patch > > > The fix proposed on HDFS-11197 didn't cover the scenario where the EZ deleted > but still under a snapshot is not a direct child of the snapshottable > directory. > Here the code snippet proposed on HDFS-11197 that would avoid the error > reported by *hdfs crypto -listZones* when a deleted EZ is still under a given > snapshot: > {noformat} > INode lastINode = null; > if (inode.getParent() != null || inode.isRoot()) { > INodesInPath iip = dir.getINodesInPath(pathName, DirOp.READ_LINK); > lastINode = iip.getLastINode(); > } > if (lastINode == null || lastINode.getId() != ezi.getINodeId()) { > continue; > } > {noformat} > It will ignore EZs when it's a direct child of a snapshot, because its parent > inode will be null, and it isn't the root inode. However, if the EZ is not > directly under snapshottable directory, its parent will not be null, and it > will pass this check, so it will fail further due *absolute path required* > validation error. > I would like to work on a fix that would also cover this scenario. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org