[
https://issues.apache.org/jira/browse/HDFS-12275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138926#comment-16138926
]
Nandakumar commented on HDFS-12275:
-----------------------------------
Thanks [~msingh] for the review.
bq. Please add a comment for this.
Added {{do random validation of data written into ozone, only subset of data is
validated.}} as description for {{validateWrites}}.
bq. it will be great to add a percentage of number of keys verified.
Done
bq. Can this poll be converted to a take ?
take will block the call and wait forever to get the data, we don't want it to
wait forever, that is why poll is used with 5 seconds timeout. We can hit a
case where the producer threads are completed and the validator thread is
waiting on the queue for data.
{{null}} is handled when poll doesn't return any value.
bq. add a test for verified keys in TestCorona.java ?
Done
uploaded patch v001 with findbugs fixes and addressed review comments.
> Ozone: Corona: Support for random validation of writes
> ------------------------------------------------------
>
> Key: HDFS-12275
> URL: https://issues.apache.org/jira/browse/HDFS-12275
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nandakumar
> Assignee: Nandakumar
> Attachments: HDFS-12275-HDFS-7240.000.patch,
> HDFS-12275-HDFS-7240.001.patch
>
>
> {{Corona}} populates ozone with data, this jira will add support in
> {{Corona}} to do random validation of data written into ozone.
> {{-validateWrites}} options will be used to enable this feature, by default
> Corona will not do any data validation.
> Note: Validation is done randomly, not for all keys.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
