[
https://issues.apache.org/jira/browse/HDFS-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142436#comment-16142436
]
Arpit Agarwal commented on HDFS-12358:
--------------------------------------
One more comment, sorry I missed it last time. The delete attempt and following
message should only be done on failure:
{code}
if (!tmpEditsFile.delete()) {
LOG.warn("Deleting " + tmpEditsFile + " has failed");
{code}
> Catch IOException when transferring edit log to Journal current dir through
> JN sync
> -----------------------------------------------------------------------------------
>
> Key: HDFS-12358
> URL: https://issues.apache.org/jira/browse/HDFS-12358
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Attachments: HDFS-12358.001.patch, HDFS-12358.002.patch
>
>
> During JN sync, a missing edit log is first downloaded from a remote JN to a
> tmp dir and then moved to the current directory (protected by the Journal's
> synchronization).
> Irrespective of whether the move succeeds or fails, we should delete the tmp
> file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]