[
https://issues.apache.org/jira/browse/HDFS-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146650#comment-16146650
]
Wei-Chiu Chuang commented on HDFS-12359:
----------------------------------------
Thanks [~xiaochen]. I reviewed the patch 001. Looks good to me overall.
The following check seems redundant.
{code:title=FSDirEncryptionZoneOp#getCurrentKeyVersion}
if (keyName == null) {
throw new IOException(zone + " is not an encryption zone.");
}
{code}
getCurrentKeyVersion would never return null.
Also, tests please?
> Re-encryption should operate with minimum KMS ACL requirements.
> ---------------------------------------------------------------
>
> Key: HDFS-12359
> URL: https://issues.apache.org/jira/browse/HDFS-12359
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: encryption
> Affects Versions: 3.0.0-beta1
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HDFS-12359.01.patch
>
>
> This was caught from KMS acl testing.
> HDFS-10899 gets the current key versions from KMS directly, which requires
> {{READ}} acls.
> It also calls invalidateCache, which requires {{MANAGEMENT}} acls.
> We should fix re-encryption to not require additional ACLs than original
> encryption.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
