[
https://issues.apache.org/jira/browse/HDFS-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatoli Shein updated HDFS-10787:
---------------------------------
Attachment: HDFS-10787.HDFS-8707.003.patch
Thanks for the reveiw, [~James C].
* In the new patch I added logic for reading multiple directories from
HADOOP_CONF_DIR, and logging warnings during the validation if some resources
in them are missing.
* The examples now reuse the file system connection code from tools_common.h.
* This patch also includes a flag BUILD_SHARED_HDFSPP which is set to TRUE by
default, but can be set to FALSE to prevent shared library from being built
(this is needed for building LIBHDFSPP as part of an external project like ORC).
* This patch also includes a number of fixes for warnings that arise when
building libhdfspp on OSx clang compiler, the addressed warnings include: extra
semi-colons, unused variables, missing override keywords, implicit conversions,
and copy elision warnings.
> libhdfs++: hdfs_configuration and configuration_loader should be accessible
> from our public API
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-10787
> URL: https://issues.apache.org/jira/browse/HDFS-10787
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Anatoli Shein
> Assignee: James Clampffer
> Attachments: HDFS-10787.HDFS-8707.000.patch,
> HDFS-10787.HDFS-8707.001.patch, HDFS-10787.HDFS-8707.002.patch,
> HDFS-10787.HDFS-8707.003.patch
>
>
> Currently, libhdfspp examples and tools all have this:
> #include "hdfspp/hdfspp.h"
> #include "common/hdfs_configuration.h"
> #include "common/configuration_loader.h"
> This is done in order to read configs and connect. We want
> hdfs_configuration and configuration_loader to be accessible just by
> including our hdfspp.h. One way to achieve that would be to create a builder,
> and would include the above libraries.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
