[
https://issues.apache.org/jira/browse/HDFS-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040391#comment-13040391
]
Todd Lipcon commented on HDFS-1954:
-----------------------------------
OK, you make a convincing argument. Here are a few small comments:
- please remove "@param fsn" since it doesn't add any docs
- please use the full word "otherwise" rather than "otw" in the javadoc
- please use the constant in DFSConfigKeys instead of the text
dfs.datanode.data.dir
- not a big deal here but we usually use StringBuilder instead of the older
(synchronized) StringBuffer in single-threaded situations
- the correct html for a line break is <br/> - we may as well fix that while
we're editing this code :)
> Improve corrupt files warning message
> -------------------------------------
>
> Key: HDFS-1954
> URL: https://issues.apache.org/jira/browse/HDFS-1954
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: philo vivero
> Assignee: Patrick Hunt
> Attachments: HDFS-1954.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> On NameNode web interface, you may get this warning:
> WARNING : There are about 32 missing blocks. Please check the log or run
> fsck.
> If the cluster was started less than 14 days before, it would be great to
> add: "Is dfs.data.dir defined?"
> If at the point of that error message, that parameter could be checked, and
> error made "OMG dfs.data.dir isn't defined!" that'd be even better. As is,
> troubleshooting undefined parameters is a difficult proposition.
> I suspect this is an easy fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
