[
https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154574#comment-16154574
]
Lei (Eddy) Xu commented on HDFS-12218:
--------------------------------------
Thanks [~andrew.wang] for the fix
One small nit:
{code}
public ECBlockGroupStats(long lowRedundancyBlockGroups, long
corruptBlockGroups, long missingBlockGroups, long
bytesInFutureBlockGroups, long pendingDeletionBlocks) {
{code}
Could you take the chance to put {{corruptBlockGroups}} and
{{bytesInFutureBlockGroups}} with their types in the same line?
+1 pending rebase to trunk.
> Rename split EC / replicated block metrics in BlockManager
> ----------------------------------------------------------
>
> Key: HDFS-12218
> URL: https://issues.apache.org/jira/browse/HDFS-12218
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding, metrics
> Affects Versions: 3.0.0-beta1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Attachments:
> 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch,
> 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch,
> 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch,
> HDFS-12218.consolidated.001.patch, HDFS-12218.consolidated.002.patch
>
>
> Noted in HDFS-12206, we should propagate the naming changes made in
> HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an
> opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
