[ 
https://issues.apache.org/jira/browse/HDFS-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154889#comment-16154889
 ] 

legend edited comment on HDFS-12393 at 9/6/17 8:57 AM:
-------------------------------------------------------

Thanks [~shahrs87] for the review.
I couldn't agree with you more. The {{TestPacketReceiver}} exists, and it 
checks the buff size accurate.
I update the patch that  using the {{totalLen}} instead of 
{{PacketHeader.PKT_LENGTHS_LEN + dataPlusChecksumLen + headerLen}}, 
so that the {{testReceiveAndMirror}} can make it accurate.


was (Author: legend):
Thanks [~shahrs87] for the review.
I couldn't agree with you more. The {{TestPacketReceiver}} exists, and it 
checks the buff size accurate.
I use the {{totalLen}} instead of {{PacketHeader.PKT_LENGTHS_LEN + 
dataPlusChecksumLen + headerLen}}, 
so that the {{testReceiveAndMirror}} can make it accurate.

> Fix incorrect package length for doRead in PacketReceiver
> ---------------------------------------------------------
>
>                 Key: HDFS-12393
>                 URL: https://issues.apache.org/jira/browse/HDFS-12393
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 3.0.0-alpha4
>            Reporter: legend
>            Assignee: legend
>              Labels: patch
>         Attachments: HDFS-12393.001.patch, HDFS-12393.002.patch
>
>
> {{headerLen=length(HEADER)}}
> {{payloadLen=length(PLEN) + length(CHECKSUMS) + length(DATA)}}
> So {{totalLen = payloadLen + headerLen + length(HLEN)}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to