[
https://issues.apache.org/jira/browse/HDFS-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160618#comment-16160618
]
Yiqun Lin edited comment on HDFS-11676 at 9/11/17 3:35 AM:
-----------------------------------------------------------
Thanks for the working, [~vagarychen]. The initial patch looks good overall.
Only two minor comments:
*CloseContainerHandler.java*
line 27: {{Expecting container create}} should be {{Expecting container close}}.
*ContainerOperationClient.java*
line 293: I am thinking if we can use state machine like
{{ContainerOperationClient#createContainer}} did, that seems better than
directly update the container state. There is already {{CLOSED}} state and
corresponding event type defined in state machine. After that, we can reuse
{{Mapping#updateContainerState}} for updating the state.
In addition, can you help check this failure test
{{hadoop.ozone.scm.node.TestNodeManager}}?
Please fix findbugs, ASF and checkstyle warning in your next patch. Thanks.
was (Author: linyiqun):
Thanks for the working, [~vagarychen]. The initial patch looks good overall.
Only two minor comments:
*CloseContainerHandler.java*
line 27: {{Expecting container create}} should be {{Expecting container close}}.
*ContainerOperationClient.java*
line 293: I am thinking if we can use state machine, that seems better than
directly update the container state. There is already {{CLOSED}} state and
corresponding event type defined in state machine. After that, we can reuse
{{Mapping#updateContainerState}} for updating the state.
In addition, can you help check this failure test
{{hadoop.ozone.scm.node.TestNodeManager}}?
Please fix findbugs, ASF and checkstyle warning in your next patch. Thanks.
> Ozone: SCM CLI: Implement close container command
> -------------------------------------------------
>
> Key: HDFS-11676
> URL: https://issues.apache.org/jira/browse/HDFS-11676
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Chen Liang
> Labels: ozoneMerge, tocheck
> Attachments: HDFS-11676-HDFS-7240.001.patch
>
>
> Implement close container command
> {code}
> hdfs scm -container close <container name>
> {code}
> This command connects to SCM and closes a container. Once the container is
> closed in the SCM, the corresponding container is closed at the appropriate
> datanode. if the container does not exist, it will return an error.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
