[ 
https://issues.apache.org/jira/browse/HDFS-12416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161083#comment-16161083
 ] 

Hadoop QA commented on HDFS-12416:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  7s{color} 
| {color:red} HDFS-12416 does not apply to trunk. Rebase required? Wrong 
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-12416 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12886391/HDFS-12416.001.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/21069/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> BlockPlacementPolicyDefault will cause NN shutdown if log level is changed
> --------------------------------------------------------------------------
>
>                 Key: HDFS-12416
>                 URL: https://issues.apache.org/jira/browse/HDFS-12416
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: block placement
>    Affects Versions: 2.7.4, 3.0.0-alpha3
>            Reporter: Suhan Mao
>         Attachments: HDFS-12416.001.patch, HDFS-12416.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> In BlockPlacementPolicyDefault.chooseRandom method.
> The code are in below structure:
> {code:java}
> StringBuilder builder = null;
>     if (LOG.isDebugEnabled()) {
>       builder = debugLoggingBuilder.get();
>       builder.setLength(0);
>       builder.append("[");
>     }
> while(numOfReplicas > 0){
> .............
> chooseDataNode(scope, excludedNodes)
> .............
> if (LOG.isDebugEnabled()) {
>         builder.append("\nNode ").append(NodeBase.getPath(chosenNode))
>             .append(" [");
>       }
> }
> {code}
> There's a possibility that the loglevel is INFO before entering while loop, 
> but the loglevel is changed to DEBUG inside the loop through web UI.
> In that case, builder is not initialized in the beginning and 
> NullPointerException will throw and this will cause NN exiting.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to