[
https://issues.apache.org/jira/browse/HDFS-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161415#comment-16161415
]
Rushabh S Shah commented on HDFS-11754:
---------------------------------------
Thanks [~erofeev] for working on this.
Overall the patch looks good.
I have one concern in unit test.
Already the hdfs unit tests runs for a long time. We should minimize the number
of times the namenode needs to be bounced.
The only reason we are bouncing the namenode to change the config value of
{{DFS_BLOCK_SIZE_DEFAULT}}
You can use {{NameNodeAdapter#spyOnNamesystem()}} and return whatever
{{FsServerDefaults}} object you want. That way you don't need to bounce
namenode.
Hope that makes sense.
One minor nit.
1. HdfsClientConfigKeys.java
Rename the config key name from
{{dfs.client.server.defaults.validity.period.ms}} to
{{dfs.client.server-defaults.validity.period.ms}}
Regarding test failures, there are lot of EC related tests that are failing
consistently.
Just cross check running all the tests with and without your patch to verify
that none of the tests failed because of your patch.
Regarding 1 ASF License warnings, if you believe that your patch didn't cause
that warning then please open a jira and hope someone from build team will take
a look.
Regarding the findbugs warning, I believe that your patch didn't cause that
warning. Just verify once that my understanding is correct.
> Make FsServerDefaults cache configurable.
> -----------------------------------------
>
> Key: HDFS-11754
> URL: https://issues.apache.org/jira/browse/HDFS-11754
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Rushabh S Shah
> Assignee: Mikhail Erofeev
> Priority: Minor
> Labels: newbie
> Fix For: 2.9.0
>
> Attachments: HDFS-11754.001.patch, HDFS-11754.002.patch,
> HDFS-11754.003.patch, HDFS-11754.004.patch
>
>
> DFSClient caches the result of FsServerDefaults for 60 minutes.
> But the 60 minutes time is not configurable.
> Continuing the discussion from HDFS-11702, it would be nice if we can make
> this configurable and make the default as 60 minutes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
