[
https://issues.apache.org/jira/browse/HDFS-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161940#comment-16161940
]
Chris Douglas commented on HDFS-11600:
--------------------------------------
bq. The proliferation of test classes still sucks from a code cleanliness POV,
so I'm open to alternative suggestions.
I haven't looked at the implementation. Could the scaffolding could be factored
into a separate utility class, and each testcase given a more descriptive
name/implementation?
Whatever form this ultimately takes, we should disable this suite of tests. As
in HDFS-12349, failing unit tests are now expected. I've stopped even looking
at the causes for TestDFSStripedOutputStreamWithFailure. Instead of adding
{{\@Ignore}} annotations to all its subclasses, would you mind if we committed
this and HDFS-12417?
> Refactor TestDFSStripedOutputStreamWithFailure test classes
> -----------------------------------------------------------
>
> Key: HDFS-11600
> URL: https://issues.apache.org/jira/browse/HDFS-11600
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0-alpha2
> Reporter: Andrew Wang
> Assignee: Elek, Marton
> Priority: Minor
> Attachments: HDFS-11600.002.patch, HDFS-11600-1.patch
>
>
> TestDFSStripedOutputStreamWithFailure has a great number of subclasses. The
> tests are parameterized based on the name of these subclasses.
> Seems like we could parameterize these tests with JUnit and then not need all
> these separate test classes.
> Another note, the tests will randomly return instead of running the test.
> Using {{Assume}} instead would make it more clear in the test output that
> these tests were skipped.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
