[
https://issues.apache.org/jira/browse/HDFS-12385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164129#comment-16164129
]
Nandakumar commented on HDFS-12385:
-----------------------------------
Thanks [~xyao] for the review.
bq. One question I have is how do we expect the client to handle the dangling
reference inside the volume/bucket/key when the AutoClosable OzoneClient is
closed? Do we need reference counting for the proxy handle before the
OzoneClient can be closed?
Once OzoneClient is closed volume/bucket/key created using that client will
become non usable. I don't think we need to have a reference count for the
proxy. Do you see any issue with this logic?
bq. Line 80: ozone.rest.servers?
Initial idea was to have this property, which points to REST Servers
(DataNodes) so that client knows where to connect. This is no more required if
we are going with cluster discovery API - [comment |
https://issues.apache.org/jira/browse/HDFS-12385?focusedCommentId=16150630&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150630].
Will remove it.
bq. Line 83: Will"localhost" will work with non-standalone case?
RestProtocol or RestClient is not yet ready, this is just a placeholder to
implement it later. This has to be verified.
bq. Do we have an open ticket for implement the RestProtol class?
As of now there is no open ticket, will create one shortly.
I will update a new patch addressing the review comments.
> Ozone: OzoneClient: Refactoring OzoneClient API
> -----------------------------------------------
>
> Key: HDFS-12385
> URL: https://issues.apache.org/jira/browse/HDFS-12385
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nandakumar
> Assignee: Nandakumar
> Labels: ozoneMerge
> Attachments: HDFS-12385-HDFS-7240.000.patch, OzoneClient.pdf
>
>
> This jira is for refactoring {{OzoneClient}} API. [^OzoneClient.pdf] will
> give an idea on how the API will look.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
