[
https://issues.apache.org/jira/browse/HDFS-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165158#comment-16165158
]
Daryn Sharp commented on HDFS-12386:
------------------------------------
# The {{FSNameSystem#serverDefaults}} is statically built to avoid unnecessary
construction of the object. It would be nice if the json-encoded string was
cached to avoid unnecessary conversion of a static object into a map and
serializing into a string.
# Not sure -1 is an appropriate value for missing parameters. I'd double check
the PB defaults for parity with hdfs.
# Default checksum should probably be 0 (represents "none") instead of -1.
# Blindly casting relatively new fields like storage policy to a primitive type
cause exceptions.
# In the test, it verifies the server defaults returned from hdfs and webhdfs
are equal. It doesn't verify that one of them actually matches the explicitly
conf values set by the test.
> Add fsserver defaults call to WebhdfsFileSystem.
> ------------------------------------------------
>
> Key: HDFS-12386
> URL: https://issues.apache.org/jira/browse/HDFS-12386
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: webhdfs
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Priority: Minor
> Attachments: HDFS-12386-1.patch, HDFS-12386.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
