[ https://issues.apache.org/jira/browse/HDFS-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168115#comment-16168115 ]
Weiwei Yang commented on HDFS-12459: ------------------------------------ Hi [~shahrs87] Thanks for elaborating your comment, it makes sense. As long as we continue to let {{WebHdfsFileSystem#getFileBlockLocations}} call {{GET_FILE_BLOCK_LOCATIONS}}, there is no need to change this class any more. The new OP {{GETFILEBLOCKLOCATIONS}} is only used in webhdfs REST calls. I have revised the patch to do so, please see v2 patch. Thanks. > Fix revert: Add new op GETFILEBLOCKLOCATIONS to WebHDFS REST API > ---------------------------------------------------------------- > > Key: HDFS-12459 > URL: https://issues.apache.org/jira/browse/HDFS-12459 > Project: Hadoop HDFS > Issue Type: Bug > Components: webhdfs > Reporter: Weiwei Yang > Assignee: Weiwei Yang > Attachments: HDFS-12459.001.patch, HDFS-12459.002.patch > > > HDFS-11156 was reverted because the implementation was non optimal, based on > the suggestion from [~shahrs87], we should avoid creating a dfs client to get > block locations because that create extra RPC call. Instead we should use > {{NamenodeProtocols#getBlockLocations}} then covert {{LocatedBlocks}} to > {{BlockLocation[]}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org