[
https://issues.apache.org/jira/browse/HDFS-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169768#comment-16169768
]
Huafeng Wang commented on HDFS-12398:
-------------------------------------
Hi [~andrew.wang], sorry I don't fully get your idea. Splitting the tests into
subclasses cannot reduce the duplication and most of them come from the
different file sizes. Did I miss anything?
And I also noticed the same duplication in TestDFSStripedOutputStream.
> Use JUnit Paramaterized test suite in TestWriteReadStripedFile
> --------------------------------------------------------------
>
> Key: HDFS-12398
> URL: https://issues.apache.org/jira/browse/HDFS-12398
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Reporter: Huafeng Wang
> Assignee: Huafeng Wang
> Priority: Trivial
> Labels: flaky-test
> Attachments: HDFS-12398.001.patch, HDFS-12398.002.patch
>
>
> The TestWriteReadStripedFile is basically doing the full product of file size
> with data node failure or not. It's better to use JUnit Paramaterized test
> suite.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
