[ 
https://issues.apache.org/jira/browse/HDFS-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170581#comment-16170581
 ] 

Kihwal Lee commented on HDFS-12371:
-----------------------------------

Test failures are not related. They either pass when ran locally or are known 
issues. E.g. HDFS-12480 is addressing TestNameNodeMetrics.

The block verification failure count was intended for actual checksum errors. I 
don't think we need to increment the failure count here.  Other than that, the 
patch looks good.
{code}
    if (block == null) {
      metrics.incrBlockVerificationFailures();
      return -1; // block not found.
    }
{code}

> "BlockVerificationFailures" and "BlocksVerified" show up as 0 in Datanode JMX
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-12371
>                 URL: https://issues.apache.org/jira/browse/HDFS-12371
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.7.1
>            Reporter: Sai Nukavarapu
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-12371.001.patch
>
>
> "BlockVerificationFailures" and "BlocksVerified" show up as 0 in Datanode JMX
> Looking at the code, i see below description.
> {noformat}
> `BlockVerificationFailures` | Total number of verifications failures | 
> `BlocksVerified` | Total number of blocks verified | 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to