[ 
https://issues.apache.org/jira/browse/HDFS-12017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170872#comment-16170872
 ] 

Xiaoyu Yao commented on HDFS-12017:
-----------------------------------

Thanks [~nandakumar131] for working on this. Patch looks good to me. I just 
have few questions:

1. We have two duplicated references OzoneConfigKeys#DFS_CONTAINER_IPC_PORT and 
ScmConfigKeys#DFS_CONTAINER_IPC_PORT to the same key "dfs.container.ipc". Can 
we consolidate it into one? I think we should keep the 
OzoneConfigKeys#DFS_CONTAINER_IPC_PORT and remove the usage of 
ScmConfigKeys#DFS_CONTAINER_IPC_PORT if possible.

2. I notice that we also have Ratis IPC port in 50012, should we change it to 
98xx range as well?
{code}
  public static final String DFS_CONTAINER_RATIS_IPC_PORT =
      "dfs.container.ratis.ipc";
  public static final int DFS_CONTAINER_RATIS_IPC_PORT_DEFAULT = 50012;
{code}

> Ozone: Container: Move IPC port to 98xx range
> ---------------------------------------------
>
>                 Key: HDFS-12017
>                 URL: https://issues.apache.org/jira/browse/HDFS-12017
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Nandakumar
>              Labels: ozoneMerge
>         Attachments: HDFS-12017-HDFS-7240.000.patch
>
>
> We use port 50011 port -- This is an old format of choosing port. Hadoop 3 
> has already moved to port ranges under 98xx. In fact all of KSM/SCM and 
> CBlock is using 98xx range. We should move 50011 to a port under 98xx.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to