[ 
https://issues.apache.org/jira/browse/HDFS-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041868#comment-13041868
 ] 

Suresh Srinivas commented on HDFS-977:
--------------------------------------

Todd, I see few commits to 0.22 that are not blockers. We should be committing 
only blockers to 0.22 at this time right? Any other content requires a vote.

BTW HDFS-1954 that was committed might have resulted in failed 
TestMissingBlocksAlert failing.

> DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-977
>                 URL: https://issues.apache.org/jira/browse/HDFS-977
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Assignee: Harsh J Chouraria
>            Priority: Trivial
>             Fix For: 0.22.0
>
>         Attachments: HDFS-977.r1.diff, HDFS-977.r2.diff
>
>
> My IDE tells me that this code snippet in 
> {{DataNode.createInterDataNodeProtocolProxy()}} is guarding the info log 
> entry at debug level, and it should be reviewed
> {code}
>     if (InterDatanodeProtocol.LOG.isDebugEnabled()) {
>       InterDatanodeProtocol.LOG.info("InterDatanodeProtocol addr=" + addr);
>     }
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to