[ 
https://issues.apache.org/jira/browse/HDFS-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173978#comment-16173978
 ] 

Weiwei Yang commented on HDFS-12503:
------------------------------------

With this patch, now user could get more help message while using the tool,

{code}
bin/hdfs oz_debug --help
usage: hdfs oz_debug -p <DB path> -o <Output DB file path>
 -h,--help                    display help message
 -o,--outPath <output path>   specify output DB file path
 -p,--dbPath <DB path>        specify DB path
{code}

Also modified description of {{outPath}} to make it more accurate, I have also 
added a check to make sure {{outPath}} is valid. Please kindly review, thanks.

> Ozone: some UX improvements to oz_debug
> ---------------------------------------
>
>                 Key: HDFS-12503
>                 URL: https://issues.apache.org/jira/browse/HDFS-12503
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HDFS-12503-HDFS-7240.001.patch, 
> HDFS-12503-HDFS-7240.002.patch
>
>
> I tried to use {{oz_debug}} to dump KSM DB for offline analysis, found a few 
> problems need to be fixed in order to make this tool easier to use. I know 
> this is a debug tool for admins, but it's still necessary to improve the UX 
> so new users (like me) can figure out how to use it without reading more docs.
> # Support *--help* argument. --help is the general arg for all hdfs scripts 
> to print usage.
> # When specify output path {{-o}}, we need to add a description to let user 
> know the path needs to be a file (instead of a dir). If the path is specified 
> as a dir, it will end up with a funny error {{unable to open the database 
> file (out of memory)}}, which is pretty misleading. And it will be helpful to 
> add a check to make sure the specified path is not an existing dir.
> # SQLCLI currently swallows exception
> # We should remove {{levelDB}} words from the command output as we are by 
> default using rocksDB



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to