[
https://issues.apache.org/jira/browse/HDFS-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175936#comment-16175936
]
Surendra Singh Lilhore commented on HDFS-11968:
-----------------------------------------------
Thanks [~msingh] for patch..
A few comments:
# No need to catch {{FileNotFoundException}} explicitly in
{{UnsetStoragePolicyCommand}} and {{SetStoragePolicyCommand}}. In
{{GetStoragePolicyCommand}} handling {{FileNotFoundException}} because of
compatibility issue. Message give by DistributedFileSystem in
{{FileNotFoundException}} is different from the message in
{{GetStoragePolicyCommand}}. I don't want to change it.
{code}
HdfsFileStatus status = dfs.getClient().getFileInfo(
Path.getPathWithoutSchemeAndAuthority(p).toString());
if (status == null) {
System.err.println("File/Directory does not exist: " + path);
return 2;
}
{code}
# Please handle the checkstyle warnings.
Otherwise LGTM..
> ViewFS: StoragePolicies commands fail with HDFS federation
> ----------------------------------------------------------
>
> Key: HDFS-11968
> URL: https://issues.apache.org/jira/browse/HDFS-11968
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 2.7.1
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Attachments: HDFS-11968.001.patch, HDFS-11968.002.patch,
> HDFS-11968.003.patch, HDFS-11968.004.patch, HDFS-11968.005.patch,
> HDFS-11968.006.patch, HDFS-11968.007.patch, HDFS-11968.008.patch,
> HDFS-11968.009.patch
>
>
> hdfs storagepolicies command fails with HDFS federation.
> For storage policies commands, a given user path should be resolved to a HDFS
> path and
> storage policy command should be applied onto the resolved HDFS path.
> {code}
> static DistributedFileSystem getDFS(Configuration conf)
> throws IOException {
> FileSystem fs = FileSystem.get(conf);
> if (!(fs instanceof DistributedFileSystem)) {
> throw new IllegalArgumentException("FileSystem " + fs.getUri() +
> " is not an HDFS file system");
> }
> return (DistributedFileSystem)fs;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
