[
https://issues.apache.org/jira/browse/HDFS-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176288#comment-16176288
]
Yiqun Lin commented on HDFS-12506:
----------------------------------
Thanks for the updating, [~cheersyang]! The latest patch looks good now. Just
found one nit:
{noformat}
- } else {
- int count = key.length() - key.replace(KSM_VOLUME_PREFIX, "").length();
- // NOTE : when delimiter gets changed, will need to change this part
- if (count == 1) {
- return KeyType.VOLUME;
- } else if (count == 2) {
- return KeyType.BUCKET;
- } else if (count >= 3) {
- return KeyType.KEY;
- } else {
- return KeyType.UNKNOWN;
- }
+ } else if (key.startsWith(KSM_VOLUME_PREFIX)) {
+ return key.replaceFirst(KSM_VOLUME_PREFIX, "")
+ .contains(KSM_BUCKET_PREFIX) ? KeyType.BUCKET : KeyType.VOLUME;
+ }else {
+ return KeyType.KEY;
}
{noformat}
Here the check for type {{KeyType.UNKNOWN;}} is missing. And one another
suggestion: can you add an UT that creating a volume/bucket with prefix char
"#"? I think method {{OzoneUtils#verifyResourceName}} already has done this
check, so just add a test to confirm this.
> Ozone: ListBucket is too slow
> -----------------------------
>
> Key: HDFS-12506
> URL: https://issues.apache.org/jira/browse/HDFS-12506
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Blocker
> Labels: ozoneMerge, performance
> Attachments: HDFS-12506-HDFS-7240.001.patch,
> HDFS-12506-HDFS-7240.002.patch, HDFS-12506-HDFS-7240.003.patch
>
>
> Generated 3 million keys in ozone, and run {{listBucket}} command to get a
> list of buckets under a volume,
> {code}
> bin/hdfs oz -listBucket http://15oz1.fyre.ibm.com:9864/vol-0-15143 -user wwei
> {code}
> this call spent over *15 seconds* to finish. The problem was caused by the
> inflexible structure of KSM DB. Right now {{ksm.db}} stores keys like
> following
> {code}
> /v1/b1
> /v1/b1/k1
> /v1/b1/k2
> /v1/b1/k3
> /v1/b2
> /v1/b2/k1
> /v1/b2/k2
> /v1/b2/k3
> /v1/b3
> /v1/b4
> {code}
> keys are sorted in nature order so when we do list buckets under a volume e.g
> /v1, we need to seek to /v1 point and start to iterate and filter keys, this
> ends up with scanning all keys under volume /v1. The problem with this design
> is we don't have an efficient approach to locate all buckets without scanning
> the keys.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
