[
https://issues.apache.org/jira/browse/HDFS-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177961#comment-16177961
]
Anu Engineer commented on HDFS-12455:
-------------------------------------
Thank you for updating the patch. Some minor comments on patch v2.
{{HttpFSFileSystem.java#createFileStatus}}
* nit : final boolean seBit --> rename as snBit ? I was not able to understand
what se stood for.
* Just wondering do we have to modify this if statement ? {{if (aBit || eBit ||
ecBit) }}
* I see that we have 14 params already to FileStatus constructor, but since
these are bits, would you consider adding a new param, or adding a new ctor
that takes a set<boolean> or add a FileStatus Builder? Any of those params
will be consistent with the current code. But please don't touch the current
constructor.
* can you also re-write the
{noformat}
if (aBit || eBit || ecBit) {
return
...
}
return
...
{noformat}
Pattern, the current code works because the fall throw is immediately visible
due to the
return statement. I suggest that you create two functions or write this code
with {{else}} so it is easy to read.
> WebHDFS - ListStatus query does not provide any information about a folder's
> "snapshot enabled" status
> ------------------------------------------------------------------------------------------------------
>
> Key: HDFS-12455
> URL: https://issues.apache.org/jira/browse/HDFS-12455
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Attachments: HDFS-12455.01.patch, HDFS-12455.02.patch
>
>
> WebHDFS - ListStatus query does not provide any information about a folder's
> "snapshot enabled" status. Since "ListStatus" lists other attributes it will
> be good to include this attribute as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
