[
https://issues.apache.org/jira/browse/HDFS-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177998#comment-16177998
]
Anu Engineer edited comment on HDFS-12529 at 9/23/17 10:58 PM:
---------------------------------------------------------------
+1, There is one checkStyle issue, I could fix that while committing. However,
the tests don't seem to check that the property is in the expected source file.
Can you add that assertion to this test, please? You can file a follow up JIRA
for this issue. I can see we have other tests that check for source.
I am going to wait for your comment to go ahead and commit this, that is if you
would like to modify this JIRA or file another one if test modification is
needed.
was (Author: anu):
+1, There is one checkStyle issue, I could fix that while committing. However,
the tests don't seem to check that the property is in the expected source file.
Can you add that assertion to this test, please? You can file a follow up JIRA
for this issue. I can see we have other tests that check for source.
> get source for config tags from file name
> -----------------------------------------
>
> Key: HDFS-12529
> URL: https://issues.apache.org/jira/browse/HDFS-12529
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Attachments: HDFS-12529.01.patch, HDFS-12529.02.patch
>
>
> For tagging related properties together use resource name as source.
> Currently it assumes source is configured in xml itself.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
