[
https://issues.apache.org/jira/browse/HDFS-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178575#comment-16178575
]
Jitendra Nath Pandey commented on HDFS-12304:
---------------------------------------------
+1 for the patch.
> Remove unused parameter from FsDatasetImpl#addVolume
> ----------------------------------------------------
>
> Key: HDFS-12304
> URL: https://issues.apache.org/jira/browse/HDFS-12304
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Minor
> Attachments: HDFS-12304.001.patch
>
>
> FsDatasetImpl has this method
> {code}
> private void addVolume(Collection<StorageLocation> dataLocations,
> Storage.StorageDirectory sd) throws IOException
> {code}
> Parameter {{dataLocations}} was introduced in HDFS-6740, this variable was
> used to get storage type info. But HDFS-10637 has changed the way of getting
> storage type in this method, making dataLocations no longer being used at all
> here. We should probably remove dataLocations for a cleaner interface.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
