[
https://issues.apache.org/jira/browse/HDFS-12498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179638#comment-16179638
]
Bharat Viswanadham commented on HDFS-12498:
-------------------------------------------
{code:java}
In DFSUtil#getJournalNodeAddresses(), we first convert the qjournal uri to a
set of journal node InetSocketAddress's and then convert that to Set<String>.
In JournalNodeSyncer#getOtherJournalNodeAddrs(), this Set<String> of journal
node address's is again converted to InetSocketAddress's. We should avoid the
double work here. DFSUtil#getJournalNodeAddresses() can be broken down into two
methods:
Set<InetSocketAddress> getJournalNodeSocketAddresses(Configuration conf);
Set<String> getJournalNodeAddresses(Configuration conf);
{code}
[~hanishakoneru] I have also thought about this. but if i add another method
for this, it will be a lot of common code among these methods. I have done
this, so that I can reuse the most of the existing code. And also even if this
conversion is done, this is a one time thing, only it will be done during
journal node startup.
Let me know your thoughts on this.
> Journal Syncer is not started in Federated + HA cluster
> -------------------------------------------------------
>
> Key: HDFS-12498
> URL: https://issues.apache.org/jira/browse/HDFS-12498
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Attachments: HDFS-12498.01.patch, HDFS-12498.02.patch, hdfs-site.xml
>
>
> Journal Syncer is not getting started in HDFS + Federated cluster, when
> dfs.shared.edits.dir.<<nameserviceId>> is provided, instead of
> dfs.namenode.shared.edits.dir
> *Log Snippet:*
> {code:java}
> 2017-09-19 21:42:40,598 WARN
> org.apache.hadoop.hdfs.qjournal.server.JournalNodeSyncer: Could not construct
> Shared Edits Uri
> 2017-09-19 21:42:40,598 WARN
> org.apache.hadoop.hdfs.qjournal.server.JournalNodeSyncer: Other JournalNode
> addresses not available. Journal Syncing cannot be done
> 2017-09-19 21:42:40,598 WARN
> org.apache.hadoop.hdfs.qjournal.server.JournalNodeSyncer: Failed to start
> SyncJournal daemon for journal ns1
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
