[ 
https://issues.apache.org/jira/browse/HDFS-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HDFS-12543:
------------------------------
    Attachment: HDFS-12543-HDFS-7240.001.patch

Post v001 patch. In this patch, size and its set/get are still present, to not 
to break unit tests.  But with this patch, the size is no longer a hard 
requirement, but just an attribute of the key, it's just info instead of 
constraint. It might be better to remove size completely from {{KsmKeyArgs}} I 
would like to leave it as a separate JIRA after this is done.

some clarification notes for reviewers:
1. if client sets a size and then close the key, this size will still be passed 
to server and visible when getting the key. While if client does not set the 
size, the size will be 0. But either case, as long as some data is written and 
committed, this value will always be the number of bytes that has been written 
by the client.
2. regardless of whether the size is set or not on key create, client can 
always keep writing (so one of the existing unit test is removed). Client 
starts with one block when the key is opened, whenever client writes beyond the 
current block, it requests for another.
3. for now, there is no append or random re-write on the key, so when a key is 
written, it gets overwritten completely from the beginning.
4. currently if client fails before commit, the open key entry and allocated 
blocks are NOT being cleaned up
5. multiple open can happen, all commit will success, but later one always 
overwrites earlier ones.

Thanks [~anu] and [~jnp] for the offline discussion!

> Ozone : allow create key without specifying size
> ------------------------------------------------
>
>                 Key: HDFS-12543
>                 URL: https://issues.apache.org/jira/browse/HDFS-12543
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-12543-HDFS-7240.001.patch
>
>
> Currently when creating a key, it is required to specify the total size of 
> the key. This makes it inconvenient for the case where a key is created and 
> data keeps coming and being appended. This JIRA is remove the requirement of 
> specifying the size on key creation, and allows appending to the key 
> indefinitely.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to