[ 
https://issues.apache.org/jira/browse/HDFS-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184464#comment-16184464
 ] 

Daryn Sharp commented on HDFS-12420:
------------------------------------

Looks good.  Is the error message output twice?  It's logging and throwing so 
presumably something at a higher level will log it again.  It's usually an 
anti-pattern to log/throw for that reason, versus logging in the catch block 
that actually handles the exception w/o re-throwing.  Not that I care much. +1

> Add an option to disallow 'namenode format -force'
> --------------------------------------------------
>
>                 Key: HDFS-12420
>                 URL: https://issues.apache.org/jira/browse/HDFS-12420
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>         Attachments: HDFS-12420.01.patch, HDFS-12420.02.patch, 
> HDFS-12420.03.patch, HDFS-12420.04.patch, HDFS-12420.05.patch, 
> HDFS-12420.06.patch, HDFS-12420.07.patch, HDFS-12420.08.patch, 
> HDFS-12420.09.patch, HDFS-12420.10.patch, HDFS-12420.11.patch
>
>
> Support for disabling NameNode format to avoid accidental formatting of 
> Namenode in production cluster. If someone really wants to delete the 
> complete fsImage, they can first delete the metadata dir and then run {code} 
> hdfs namenode -format{code} manually.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to