[
https://issues.apache.org/jira/browse/HDFS-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185126#comment-16185126
]
Xiaoyu Yao edited comment on HDFS-12060 at 9/28/17 11:55 PM:
-------------------------------------------------------------
Thanks [~nandakumar131] for the patch. It looks pretty good to me overall. I
just have few minor comments.
Do we need to update the KSM CLI to use these new list APIs for better
performance?
ClientProtocol.java
Line 124: At interface level, I would like to have a maxListResult as a
parameter to the API instead of assuming ozone.key.cache.size.
This applies to the other list APIs as well.
Line 235: prevKey should be prevBucket
Do we limit the maximum number bucket returned per listBuckets call with
ozone.key.cache.size?
ObjectStore.java
Line 117: we should use the UGI#getShortUserName()
RpcClient.java
If we could make the change in the API with the additional parameter, we will
use the ozone.key.cache.size only if
the maxListResult is not specified.
was (Author: xyao):
Thanks [~msingh] for the patch. It looks pretty good to me overall. I just have
few minor comments.
Do we need to update the KSM CLI to use these new list APIs for better
performance?
ClientProtocol.java
Line 124: At interface level, I would like to have a maxListResult as a
parameter to the API instead of assuming ozone.key.cache.size.
This applies to the other list APIs as well.
Line 235: prevKey should be prevBucket
Do we limit the maximum number bucket returned per listBuckets call with
ozone.key.cache.size?
ObjectStore.java
Line 117: we should use the UGI#getShortUserName()
RpcClient.java
If we could make the change in the API with the additional parameter, we will
use the ozone.key.cache.size only if
the maxListResult is not specified.
> Ozone: OzoneClient: Add list calls in RpcClient
> -----------------------------------------------
>
> Key: HDFS-12060
> URL: https://issues.apache.org/jira/browse/HDFS-12060
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Nandakumar
> Assignee: Nandakumar
> Labels: ozoneMerge
> Attachments: HDFS-12060-HDFS-7240.000.patch,
> HDFS-12060-HDFS-7240.001.patch, HDFS-12060-HDFS-7240.002.patch
>
>
> Support for {{listVolumes}}, {{listBuckets}}, {{listKeys}} in {{RpcClient}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
