[ 
https://issues.apache.org/jira/browse/HDFS-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Mackrory updated HDFS-11096:
---------------------------------
    Attachment: HDFS-11096.004.patch

.004 patch:

* Added more helpful logging so set -v and set -x aren't needed, and removed 
those.
* Changed to run as non-root - Hadoop environment was actually not set up 
because it was root, so now I can actually use create-release. This involved 
quite a big change to the Docker wrapper scripts to move EVERYTHING that 
require root privileges into separate steps before kicking off the actual test 
run that no longer used or needed root at all.
* Locally at least, I have now fixed *all* shellcheck issues.

I actually feel pretty strongly about keeping set -e here. I usually like to 
use "if ...; then" for handling likely errors, but I do see your point about 
not having a way to have responses conditional on the specific error code. But 
in this case every step is required and there's not a ton we can do to recover 
from a failed command that wouldn't require fixes to the tests or the Hadoop 
from a human. The alternative is to have test runs advance far beyond the root 
cause of failure and be harder to troubleshoot, or wrap a lot of unnecessary 
checks for success around (quite literally) everything. Thoughts?

Currently YARN rolling upgrades are actually failing because the Hadoop 3 
ResourceManager is using URIs like http://ns1:8020/... (logical namespace name 
used as though it's a hostname). Not sure where that's coming from yet, I need 
to dig there, but I doubt the fix there will invalidate much review of the 
current code.

> Support rolling upgrade between 2.x and 3.x
> -------------------------------------------
>
>                 Key: HDFS-11096
>                 URL: https://issues.apache.org/jira/browse/HDFS-11096
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rolling upgrades
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Andrew Wang
>            Assignee: Sean Mackrory
>            Priority: Blocker
>         Attachments: HDFS-11096.001.patch, HDFS-11096.002.patch, 
> HDFS-11096.003.patch, HDFS-11096.004.patch
>
>
> trunk has a minimum software version of 3.0.0-alpha1. This means we can't 
> rolling upgrade between branch-2 and trunk.
> This is a showstopper for large deployments. Unless there are very compelling 
> reasons to break compatibility, let's restore the ability to rolling upgrade 
> to 3.x releases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to