[
https://issues.apache.org/jira/browse/HDFS-12569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186747#comment-16186747
]
Andrew Wang commented on HDFS-12569:
------------------------------------
Fix LGTM, could you also add some javadoc to unprotectedRemoveXattrs to help
avoid this in the future? +1 pending that and Jenkins.
Seems like we need some more testing for this area of the code generally, could
you file a follow-on JIRA? This covers restarting from the edit log, but we
should also do one that recovers from a checkpoint too.
> Unset EC policy logs empty payload in edit log
> ----------------------------------------------
>
> Key: HDFS-12569
> URL: https://issues.apache.org/jira/browse/HDFS-12569
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
> Affects Versions: 3.0.0-alpha4
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Blocker
> Attachments: HDFS-12569.00.patch
>
>
> The edit log generated by {{hdfs ec -unsetPolicy}} generates an
> {{OP_REMOVE_XATTR}} entry in edit logs, but the payload like xattr namespace
> / name / vaue are missing:
> {code}
> <RECORD>
> <OPCODE>OP_REMOVE_XATTR</OPCODE>
> <DATA>
> <TXID>420481</TXID>
> <SRC>/</SRC>
> <RPC_CLIENTID>b098e758-9d7f-48b7-aa91-80ca52133b09</RPC_CLIENTID>
> <RPC_CALLID>0</RPC_CALLID>
> </DATA>
> </RECORD>
> {code}
> As a result, when Active NN restarts, or the Standby NN replay edits, this op
> has not effect.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
