[ 
https://issues.apache.org/jira/browse/HDFS-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188972#comment-16188972
 ] 

Anu Engineer commented on HDFS-12576:
-------------------------------------

[~bharatviswa] Thanks for the very detailed off-line explanation. It looks like 
the older shell check is failing, this new check ensures that JNs are not 
started if the variable is indeed not set.
To understand this change HDFS-12486 and HDFS-12375 patches are essential. The 
original sed based parsing was replaced with java code, but the return was an 
empty string with \n from the java code. The shell script checks for \n, but 
*IFS* strips it out. So, unfortunately, the shell check fails and Journal nodes 
are started even if the Journal nodes are not set. This new change fixes it via 
making sure that JOURNAL_NODE variable is not zero length instead of *'\n' 
check. This makes sure that JN is not started until we have a valid setting.

+1, I will commit this shortly. 
 

> JournalNodes are getting started, even though dfs.namenode.shared.edits.dir 
> is not configured
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12576
>                 URL: https://issues.apache.org/jira/browse/HDFS-12576
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>         Attachments: HDFS-12576.01.patch
>
>
> dfs.namenode.shared.edits.dir is not configured, but still journal node is 
> getting started.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to