[
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188994#comment-16188994
]
Xiaoyu Yao commented on HDFS-12568:
-----------------------------------
The patch looks excellent to me. I just have few NITs in ozone-default.xml.
Ozone-default.xml
Line 64: ozone->CBLOCK,PERFORMANCE?
Lin 126: can we change to dfs.cblock.container.size.gb to be consistent with
other Ozone keys related to size.
Line 138/251: Should we use ${hadoop.tmp.dir}/cblockCacheDB?
Line 327: should we add a CONTAINER tag for dfs.container.ipc.random.port?
Line 337: should we add a RATIS tag for
dfs.container.ratis.datanode.storage.dir?
Line 448: NIT: can you add xml comment to mark the beginning of the CLIENT
related keys?
> Ozone: Cleanup the ozone-default.xml
> ------------------------------------
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Blocker
> Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch,
> HDFS-12568-HDFS-7240.002.patch, HDFS-12568-HDFS-7240.003.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
