[
https://issues.apache.org/jira/browse/HDFS-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191348#comment-16191348
]
Nandakumar commented on HDFS-12543:
-----------------------------------
Thanks [~vagarychen] for working on this, the patch looks pretty good to me.
Few comments:
bq. It might be better to remove size completely from {{KsmKeyArgs}} I would
like to leave it as a separate JIRA after this is done.
If the plan is to remove size from {{KsmKeyArgs}}, can we also remove the
dependency of size from {{KeyManagerImpl#openKey}}. I understand the
optimization done with key size, but if we are going to remove it later why
depend on it now? I don't have any cleaner approach to suggest for optimizing
block allocation for big keys.
*KeyManagerImpl.java*
{{commitKey}}: we have to update actual size of the key during commit.
Line 201: Even for a 0 length key we are initially updating the size as
{{scmBlockSize}} which is not necessary, we can set the size to 0.
Line 137: The log message can be changed, we are not actually committing the
key here.
*KeySpaceManager.java*
Line 497: {{metrics.incNumBlockAllocates()}} this doesn't give us the actual
number of blocks allocated, since we are also allocating blocks as part of
{{openKey}}. Can we change this metrics name from {{numBlockAllocate}} to
{{numAllocateBlockCalls}}?
> Ozone : allow create key without specifying size
> ------------------------------------------------
>
> Key: HDFS-12543
> URL: https://issues.apache.org/jira/browse/HDFS-12543
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Labels: ozoneMerge
> Attachments: HDFS-12543-HDFS-7240.001.patch,
> HDFS-12543-HDFS-7240.002.patch, HDFS-12543-HDFS-7240.003.patch,
> HDFS-12543-HDFS-7240.004.patch, HDFS-12543-HDFS-7240.005.patch,
> HDFS-12543-HDFS-7240.006.patch, HDFS-12543-HDFS-7240.007.patch,
> HDFS-12543-HDFS-7240.008.patch, HDFS-12543-HDFS-7240.009.patch
>
>
> Currently when creating a key, it is required to specify the total size of
> the key. This makes it inconvenient for the case where a key is created and
> data keeps coming and being appended. This JIRA is remove the requirement of
> specifying the size on key creation, and allows appending to the key
> indefinitely.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
