[
https://issues.apache.org/jira/browse/HDFS-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195787#comment-16195787
]
Tsz Wo Nicholas Sze commented on HDFS-12598:
--------------------------------------------
The new patch looks good. Some minor comments:
- Let's use try-with-resource for the following:
{code} //RatisManagerImpl
XceiverClientRatis client =
XceiverClientRatis.newXceiverClientRatis(pipeline, conf);
client.createPipeline(pipeline.getPipelineName(), pipeline.getMachines());
client.close();
{code}
i.e.
{code}
try(XceiverClientRatis client =
XceiverClientRatis.newXceiverClientRatis(pipeline, conf)) {
client.createPipeline(pipeline.getPipelineName(),
pipeline.getMachines());
}
{code}
- We should not print info message in client code. How about change the below
to debug or trace?
{code} //XceiverClientRatis
LOG.info("initializing pipeline:{} with nodes:{}", clusterId, newPeers);
{code}
> Ozone: Fix 3 node ratis replication in Ozone
> --------------------------------------------
>
> Key: HDFS-12598
> URL: https://issues.apache.org/jira/browse/HDFS-12598
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Labels: ozoneMerge
> Fix For: HDFS-7240
>
> Attachments: HDFS-12598-HDFS-7240.001.patch,
> HDFS-12598-HDFS-7240.002.patch, HDFS-12598-HDFS-7240.003.patch
>
>
> Enabling ratis 3 node replication on ozone currently fails because
> XceiverServerRatis doesn't initialize correctly because the server id is not
> initialized correctly. Uploading an initial patch for early feedback. Will
> upload an updated patch after testing on the cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
