[
https://issues.apache.org/jira/browse/HDFS-12411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoyu Yao updated HDFS-12411:
------------------------------
Attachment: HDFS-12411-HDFS-7240.006.patch
Thanks [~yuanbo] for the review. I've attached a rebased new patch to address
the feedbacks.
bq. 1. ContainerData.java line 49 Can we rename the size as maxSize, it's a bit
confusing.
Done.
bq. 2. ContainerReport.java I've seen a lot of representing classes which only
contain getters and setters, I'm wondering whether these classes are really
useful since we could use protobuf classes instead. I'd prefer to abandon this
kind of classes but I'm opening on this point.
This was introduced for different purposes. ContainerData was used by
ContainerManagerImpl for persistence. ContainerStatus was used by
ContainerManagerImpl, BlockDeletionService and container report. We can open a
separate ticket to see if we could refactor to use protobuf msg directly.
bq. 3.OzoneConfigKeys.java line 159 Can we add this parameter into
ozone-default.xml?
Done.
bq. 4. I saw some refactor changes in your patch, can we file another JIRA to
address it. But I'm good if you want to keep those changes.
Choose to keep the change as most of the refactors are needed for container
report such as the change in MetadataKeyFilters and also a few unit tests clean
up.
> Ozone: Add container usage information to DN container report
> -------------------------------------------------------------
>
> Key: HDFS-12411
> URL: https://issues.apache.org/jira/browse/HDFS-12411
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, scm
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Labels: ozoneMerge
> Attachments: HDFS-12411-HDFS-7240.001.patch,
> HDFS-12411-HDFS-7240.002.patch, HDFS-12411-HDFS-7240.003.patch,
> HDFS-12411-HDFS-7240.004.patch, HDFS-12411-HDFS-7240.005.patch
>
>
> Current DN ReportState for container only has a counter, we will need to
> include individual container usage information so that SCM can
> * close container when they are full
> * assign container for block service with different policies.
> * etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
