[
https://issues.apache.org/jira/browse/HDFS-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199700#comment-16199700
]
Nandakumar commented on HDFS-12519:
-----------------------------------
Thanks [~vagarychen] for the through review.
bq. {{LeaseManager}}, how about adding a heap in addition to activeLeases?
The problem with using {{PriorityQueue}} is that re-ordering doesn't happen if
an element inside queue is modified. We have {{public void renew(long
timeout)}} in {{Lease}} which modifies the timeout value based on which the
ordering will be done. I agree on the performance gain we will get by adding
{{PriorityQueue}}, in that case we might have to remove the support for lease
renewal.
bq. {{LeaseManager#LeaseMonitor#run}} About the interrupt in acquire, will the
following case happen?
Good point.
>>will the lease monitor thread got stopped?
When interrupt is called on a running thread the interrupt flag is set, the
thread won't be stopped. We can check the interrupt flag and perform required
operations.
>>it seems it is possible that whenever leaseMonitor is checking timeout, an
>>acquire call may come in and interrupt leaseMonitor...
This can be handled, will update the patch to handle this situation.
> Ozone: Add a Lease Manager to SCM
> ---------------------------------
>
> Key: HDFS-12519
> URL: https://issues.apache.org/jira/browse/HDFS-12519
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Anu Engineer
> Assignee: Nandakumar
> Labels: ozoneMerge
> Attachments: HDFS-12519-HDFS-7240.000.patch,
> HDFS-12519-HDFS-7240.001.patch, HDFS-12519-HDFS-7240.002.patch
>
>
> Many objects, including Containers and pipelines can time out during creating
> process. We need a way to track these timeouts. This lease Manager allows SCM
> to hold a lease on these objects and helps SCM timeout waiting for creating
> of these objects.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
