[
https://issues.apache.org/jira/browse/HDFS-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199928#comment-16199928
]
SammiChen commented on HDFS-12613:
----------------------------------
Hi [~eddyxu], thanks for reporting and working on it.
1. Apart from add {{synchronized}} on {{release}}, {{performEncodeImpl}} and
{{performDecodeImpl}} can also have the {{synchronized}} keyword
2. I see you add the NULL check of {{nativeCoder}} in native code. We can also
check it's status in JAVA code. If it's already null, we don't need to call the
native code through JNI.
> Native EC coder should implement release() as idempotent function.
> ------------------------------------------------------------------
>
> Key: HDFS-12613
> URL: https://issues.apache.org/jira/browse/HDFS-12613
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
> Affects Versions: 3.0.0-beta1
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HDFS-12613.00.patch, HDFS-12613.01.patch
>
>
> Recently, we found native EC coder crashes JVM because
> {{NativeRSDecoder#release()}} being called multiple times (HDFS-12612 and
> HDFS-12606).
> We should strength the implement the native code to make {{release()}}
> idempotent as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
