[
https://issues.apache.org/jira/browse/HDFS-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204544#comment-16204544
]
Akira Ajisaka commented on HDFS-12650:
--------------------------------------
Mostly looks good to me. Minor comments:
1. {code}
- if (LOG.isDebugEnabled()) {
- LOG.debug(name + " is interrupted", ie);
- }
+ LOG.debug("{} is interrupted", name, ie);
{code}
The indent is incorrect.
2. {code}
- LOG.debug("Lease recovery for inode " + id + " is complete. " +
- "File closed.");
+ LOG.debug("Lease recovery for inode {} is complete.File closed.",
+ id);
{code}
Would you add a whitespace between 'complete.' and 'File'?
3. Would you fix the checkstyle warnings?
> Use slf4j instead of log4j in LeaseManager
> ------------------------------------------
>
> Key: HDFS-12650
> URL: https://issues.apache.org/jira/browse/HDFS-12650
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Fix For: 3.1.0
>
> Attachments: HDFS-12650.01.patch
>
>
> LeaseManager is still using log4j dependencies. We should move those to
> slf4j.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
