[
https://issues.apache.org/jira/browse/HDFS-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205650#comment-16205650
]
Rakesh R commented on HDFS-12310:
---------------------------------
Thanks [~surendrasingh]. Good work!
Adding few comments on the patch.
# Rather than using the acronym SPS, how about rename {{SPSStatus}} ->
{{StoragePolicySatisfyPathStatus}}?
{code}
/**
* Storage policy satisfy path status.
*/
public enum StoragePolicySatisfyPathStatus
{code}
# Rename {{checkPolicySatisfierStatus}} ->
{{checkStoragePolicySatisfyPathStatus}} as 'Satisfier' word would confuse with
the SPS daemon. Also, please correct javadoc.
{code}
+ /**
+ * Check if StoragePolicySatisfier is running.
+ * @return true if StoragePolicySatisfier is running
+ * @throws IOException
+ */
+ @Idempotent
+ SPSStatus checkPolicySatisfierStatus(String path) throws IOException;
{code}
# Please rename {{SPSStatusInfo}} -> {{StoragePolicySatisfyPathStatusInfo}}
# Typo : SUSCCESS more than 5 min => SUCCESS more than 5 min
# Please add some comments about the purpose of this constant and unit. Also,
rename {{statusClearanceTime}} -> {{statusClearanceElapsedTimeMs}}
# Can we call SPSStatusInfo#time as 'SPSStatusInfo#lastStatusUpdateTime' and
use Time.monotonicNow() instead of System.currentTimeMillis()
# Since path has life cycle Status#PENDING -> Status#IN_PROGRESS ->
Status#SUCCESS. Can we document this status changes and possible transitions.
> [SPS]: Provide an option to track the status of in progress requests
> --------------------------------------------------------------------
>
> Key: HDFS-12310
> URL: https://issues.apache.org/jira/browse/HDFS-12310
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Uma Maheswara Rao G
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-12310-HDFS-10285-01.patch,
> HDFS-12310-HDFS-10285-02.patch
>
>
> As per the [~andrew.wang] 's review comments in HDFS-10285, This is the JIRA
> for tracking about the options how we track the progress of SPS requests.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
