[
https://issues.apache.org/jira/browse/HDFS-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDFS-11468:
-----------------------------
Attachment: HDFS-11468-HDFS-7240.003.patch
Thanks for the review, [~cheersyang].
For your fist comment, I think {{lastConainerReportTotalSize}} is too long.
Since metric is the data of aggregated statistics. I'd like to update this as
{{ConainerSize}}. This will look simplify and also good understanding.
bq. second, as we already have SCMMXBean, can we merge these metrics to that
class?
I don't agree with this. There will be some more type scm metrics added into
SCMMetrics in the future. Why we merge these metrics into that class? SCMMXBean
is just the JMX interface for exposing scm information.
Attach the update for addressing first comment.
> Ozone: SCM: Add Node Metrics for SCM
> ------------------------------------
>
> Key: HDFS-11468
> URL: https://issues.apache.org/jira/browse/HDFS-11468
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Xiaoyu Yao
> Assignee: Yiqun Lin
> Priority: Critical
> Labels: OzonePostMerge
> Attachments: HDFS-11468-HDFS-7240.001.patch,
> HDFS-11468-HDFS-7240.002.patch, HDFS-11468-HDFS-7240.003.patch
>
>
> This ticket is opened to add node metrics in SCM based on heartbeat, node
> report and container report from datanodes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
