[ https://issues.apache.org/jira/browse/HDFS-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wei-Chiu Chuang updated HDFS-12619: ----------------------------------- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 2.8.3 2.9.0 Status: Resolved (was: Patch Available) Thanks [~hanishakoneru] and [~xiaochen] for the review. Patch 001 was committed in trunk (3.0.0), branch-2 (2.9.0) and branch-2.8 (2.8.3) > Do not catch and throw unchecked exceptions if IBRs fail to process > ------------------------------------------------------------------- > > Key: HDFS-12619 > URL: https://issues.apache.org/jira/browse/HDFS-12619 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Affects Versions: 2.8.0, 2.7.3, 3.0.0-alpha1 > Reporter: Wei-Chiu Chuang > Assignee: Wei-Chiu Chuang > Priority: Minor > Fix For: 2.9.0, 2.8.3, 3.0.0 > > Attachments: HDFS-12619.001.patch > > > HDFS-9198 added the following code > {code:title=BlockManager#processIncrementalBlockReport} > public void processIncrementalBlockReport(final DatanodeID nodeID, > final StorageReceivedDeletedBlocks srdb) throws IOException { > ... > try { > processIncrementalBlockReport(node, srdb); > } catch (Exception ex) { > node.setForceRegistration(true); > throw ex; > } > } > {code} > In Apache Hadoop 2.7.x ~ 3.0, the code snippet is accepted by Java compiler. > However, when I attempted to backport it to a CDH5.3 release (based on Apache > Hadoop 2.5.0), the compiler complains the exception is unhandled, because the > method defines it throws IOException instead of Exception. > While the code compiles for Apache Hadoop 2.7.x ~ 3.0, I feel it is not a > good practice to catch an unchecked exception and then rethrow it. How about > rewriting it with a finally block and a conditional variable? -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org