[
https://issues.apache.org/jira/browse/HDFS-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211660#comment-16211660
]
Íñigo Goiri edited comment on HDFS-12620 at 10/19/17 8:15 PM:
--------------------------------------------------------------
I got the following:
{code}
Total Elapsed time: 925m 35s
-1 overall
_____ _ _ _
| ___|_ _(_) |_ _ _ __ ___| |
| |_ / _` | | | | | | '__/ _ \ |
| _| (_| | | | |_| | | | __/_|
|_| \__,_|_|_|\__,_|_| \___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | shellcheck | 0m 0s | Shellcheck was not available.
| 0 | findbugs | 0m 0s | Findbugs executables are not available.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 25 new or
| | | | modified test files.
| +1 | mvninstall | 5m 53s | branch-2 passed
| +1 | compile | 0m 37s | branch-2 passed
| +1 | checkstyle | 0m 28s | branch-2 passed
| +1 | mvnsite | 0m 45s | branch-2 passed
| +1 | mvneclipse | 0m 14s | branch-2 passed
| +1 | javadoc | 0m 50s | branch-2 passed
| +1 | mvninstall | 0m 38s | the patch passed
| +1 | compile | 0m 36s | the patch passed
| +1 | cc | 0m 36s | the patch passed
| +1 | javac | 0m 36s | the patch passed
| -1 | checkstyle | 0m 27s | hadoop-hdfs-project/hadoop-hdfs: The
| | | | patch generated 11 new + 624 unchanged -
| | | | 0 fixed = 635 total (was 624)
| +1 | mvnsite | 0m 44s | the patch passed
| +1 | mvneclipse | 0m 11s | the patch passed
| +1 | shelldocs | 0m 3s | There were no new shelldocs issues.
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | xml | 0m 1s | The patch has no ill-formed XML file.
| +1 | javadoc | 0m 54s | the patch passed
| -1 | unit | 891m 25s | hadoop-hdfs in the patch failed.
| +1 | asflicense | 20m 29s | The patch does not generate ASF License
| | | | warnings.
| | | 925m 35s |
Reason | Tests
Failed junit tests | hadoop.hdfs.server.datanode.TestDataNodePeerMetrics
| hadoop.hdfs.server.datanode.TestDataNodeUUID
|
hadoop.hdfs.server.namenode.startupprogress.TestStartupProgress
|
hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
Timed out junit tests |
org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy
|
org.apache.hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
| org.apache.hadoop.hdfs.TestRestartDFS
|
org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
|
org.apache.hadoop.hdfs.server.datanode.TestBlockCountersInPendingIBR
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
|
org.apache.hadoop.hdfs.server.datanode.TestReadOnlySharedStorage
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetricsLogger
|
org.apache.hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeFaultInjector
|
org.apache.hadoop.hdfs.server.namenode.TestNestedEncryptionZones
|
org.apache.hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMXBean
|
org.apache.hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
|
org.apache.hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
|
org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports
|
org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache
|
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
|
org.apache.hadoop.hdfs.server.datanode.TestBlockScanner
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeLifeline
| org.apache.hadoop.hdfs.server.datanode.TestDiskError
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeReconfiguration
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
|
org.apache.hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeTransferSocketSize
|
org.apache.hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
| org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
|
org.apache.hadoop.hdfs.server.datanode.TestRefreshNamenodes
|
org.apache.hadoop.hdfs.server.datanode.TestTransferRbw
|
org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeMetrics
|
org.apache.hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement
|
org.apache.hadoop.hdfs.server.datanode.TestLargeBlockReport
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit
| org.apache.hadoop.hdfs.server.datanode.TestBatchIbr
|
org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
| org.apache.hadoop.hdfs.server.datanode.TestHSync
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestWriteToReplica
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol
|
org.apache.hadoop.hdfs.server.datanode.TestCachingStrategy
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeECN
|
org.apache.hadoop.hdfs.server.datanode.TestIncrementalBrVariations
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
|
org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
|
org.apache.hadoop.hdfs.server.datanode.TestStorageReport
|
org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Issue | HDFS-12620 |
| Optional Tests | asflicense xml compile javac javadoc mvninstall
mvnsite unit shellcheck shelldocs findbugs checkstyle cc |
| uname | Linux cisl-linux-002 3.10.0-514.el7.x86_64 #1 SMP Tue Nov 22 16:42:41
UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/hadoop/hadoop-oss/patchprocess/yetus-0.3.0/lib/precommit/personality/hadoop.sh
|
| git revision | branch-2 / 0aa1b62 |
| Default Java | 1.7.0_151 |
| checkstyle |
/tmp/yetus-32367.13477/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | /tmp/yetus-32367.13477/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit test logs |
/tmp/yetus-32367.13477/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
{code}
The unit tests don't seem very realistic though.
I tested all of them one by one and all passed.
The check styles are what I've already mentioned.
I'm trying one last time with jenkins with version 011 but if it doesn't go
through, I would stick to this.
was (Author: elgoiri):
I got the following:
{code}
Total Elapsed time: 925m 35s
-1 overall
_____ _ _ _
| ___|_ _(_) |_ _ _ __ ___| |
| |_ / _` | | | | | | '__/ _ \ |
| _| (_| | | | |_| | | | __/_|
|_| \__,_|_|_|\__,_|_| \___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | shellcheck | 0m 0s | Shellcheck was not available.
| 0 | findbugs | 0m 0s | Findbugs executables are not available.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 25 new or
| | | | modified test files.
| +1 | mvninstall | 5m 53s | branch-2 passed
| +1 | compile | 0m 37s | branch-2 passed
| +1 | checkstyle | 0m 28s | branch-2 passed
| +1 | mvnsite | 0m 45s | branch-2 passed
| +1 | mvneclipse | 0m 14s | branch-2 passed
| +1 | javadoc | 0m 50s | branch-2 passed
| +1 | mvninstall | 0m 38s | the patch passed
| +1 | compile | 0m 36s | the patch passed
| +1 | cc | 0m 36s | the patch passed
| +1 | javac | 0m 36s | the patch passed
| -1 | checkstyle | 0m 27s | hadoop-hdfs-project/hadoop-hdfs: The
| | | | patch generated 11 new + 624 unchanged -
| | | | 0 fixed = 635 total (was 624)
| +1 | mvnsite | 0m 44s | the patch passed
| +1 | mvneclipse | 0m 11s | the patch passed
| +1 | shelldocs | 0m 3s | There were no new shelldocs issues.
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | xml | 0m 1s | The patch has no ill-formed XML file.
| +1 | javadoc | 0m 54s | the patch passed
| -1 | unit | 891m 25s | hadoop-hdfs in the patch failed.
| +1 | asflicense | 20m 29s | The patch does not generate ASF License
| | | | warnings.
| | | 925m 35s |
Reason | Tests
Failed junit tests | hadoop.hdfs.server.datanode.TestDataNodePeerMetrics
| hadoop.hdfs.server.datanode.TestDataNodeUUID
|
hadoop.hdfs.server.namenode.startupprogress.TestStartupProgress
|
hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
Timed out junit tests |
org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy
|
org.apache.hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
| org.apache.hadoop.hdfs.TestRestartDFS
|
org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
|
org.apache.hadoop.hdfs.server.datanode.TestBlockCountersInPendingIBR
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
|
org.apache.hadoop.hdfs.server.datanode.TestReadOnlySharedStorage
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetricsLogger
|
org.apache.hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeFaultInjector
|
org.apache.hadoop.hdfs.server.namenode.TestNestedEncryptionZones
|
org.apache.hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMXBean
|
org.apache.hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
|
org.apache.hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
|
org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports
|
org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache
|
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
|
org.apache.hadoop.hdfs.server.datanode.TestBlockScanner
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeLifeline
| org.apache.hadoop.hdfs.server.datanode.TestDiskError
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeReconfiguration
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
|
org.apache.hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeTransferSocketSize
|
org.apache.hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
| org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
|
org.apache.hadoop.hdfs.server.datanode.TestRefreshNamenodes
|
org.apache.hadoop.hdfs.server.datanode.TestTransferRbw
|
org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeMetrics
|
org.apache.hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement
|
org.apache.hadoop.hdfs.server.datanode.TestLargeBlockReport
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit
| org.apache.hadoop.hdfs.server.datanode.TestBatchIbr
|
org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
| org.apache.hadoop.hdfs.server.datanode.TestHSync
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestWriteToReplica
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol
|
org.apache.hadoop.hdfs.server.datanode.TestCachingStrategy
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeECN
|
org.apache.hadoop.hdfs.server.datanode.TestIncrementalBrVariations
|
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
|
org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
|
org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
|
org.apache.hadoop.hdfs.server.datanode.TestStorageReport
|
org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Issue | HDFS-12620 |
| Optional Tests | asflicense xml compile javac javadoc mvninstall
mvnsite unit shellcheck shelldocs findbugs checkstyle cc |
| uname | Linux cisl-linux-002 3.10.0-514.el7.x86_64 #1 SMP Tue Nov 22 16:42:41
UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/hadoop/hadoop-oss/patchprocess/yetus-0.3.0/lib/precommit/personality/hadoop.sh
|
| git revision | branch-2 / 0aa1b62 |
| Default Java | 1.7.0_151 |
| checkstyle |
/tmp/yetus-32367.13477/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | /tmp/yetus-32367.13477/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit test logs |
/tmp/yetus-32367.13477/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
{code}
The unit tests don't seem very realistic though.
I test all of them one by one and all passed.
The check styles are what I've already mentioned.
I'm trying one last time with jenkins with version 011 but if it doesn't go
through, I would stick to this.
> Backporting HDFS-10467 to branch-2
> ----------------------------------
>
> Key: HDFS-12620
> URL: https://issues.apache.org/jira/browse/HDFS-12620
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Attachments: HDFS-10467-branch-2.001.patch,
> HDFS-10467-branch-2.002.patch, HDFS-10467-branch-2.003.patch,
> HDFS-10467-branch-2.patch, HDFS-12620-branch-2.000.patch,
> HDFS-12620-branch-2.004.patch, HDFS-12620-branch-2.005.patch,
> HDFS-12620-branch-2.006.patch, HDFS-12620-branch-2.007.patch,
> HDFS-12620-branch-2.008.patch, HDFS-12620-branch-2.009.patch,
> HDFS-12620-branch-2.010.patch, HDFS-12620-branch-2.011.patch
>
>
> When backporting HDFS-10467, there are a few things that changed:
> * {{bin\hdfs}}
> * {{ClientProtocol}}
> * Java 7 not supporting referencing functions
> * {{org.eclipse.jetty.util.ajax.JSON}} in branch-2 is
> {{org.mortbay.util.ajax.JSON}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
