[ 
https://issues.apache.org/jira/browse/HDFS-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213001#comment-16213001
 ] 

Íñigo Goiri commented on HDFS-12607:
------------------------------------

* In {{ProvidedStorageMap}}, can we use the {{Logger}} format?
* The comment in {{ProvidedStorageMap#setState()}} is not very clear. Something 
along the lines of the JIRA description would be better. Maybe for the whole 
{{setState()}} method
* Capital for the first word of the comments?
* Can we make {{numFiles > 0}} in the unit test? Should we fail if we 
{{numFiles}} is set to 0 as we are not testing anything?
* Should we do {{waitActive()}} in the test for every file?

> [READ] Even one dead datanode with PROVIDED storage results in 
> ProvidedStorageInfo being marked as FAILED
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12607
>                 URL: https://issues.apache.org/jira/browse/HDFS-12607
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Virajith Jalaparti
>            Assignee: Virajith Jalaparti
>         Attachments: HDFS-12607-HDFS-9806.001.patch, HDFS-12607.repro.patch
>
>
> When a DN configured with PROVIDED storage is marked as dead by the NN, the 
> state of {{providedStorageInfo}} in {{ProvidedStorageMap}} is set to FAILED, 
> and never becomes NORMAL. The state should change to FAILED only if all 
> datanodes with PROVIDED storage are dead, and should be restored back to 
> NORMAL when a Datanode with NORMAL DatanodeStorage reports in.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to