[ 
https://issues.apache.org/jira/browse/HDFS-12521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215976#comment-16215976
 ] 

Anu Engineer edited comment on HDFS-12521 at 10/23/17 10:53 PM:
----------------------------------------------------------------

bq. The listContainer json output changes after the patch as now the function 
outputs a list of ContainerInfo instead of list of Pipelines. Therefore the 
json now contains field from ContainerInfo class as well. 

care to post a sample of how these changes look like?Is there any benefit for 
the end-user due to this change?
 

I am +1 on these changes, but I am very nervous when we make format changes 
like this JSON output. Can we please verify that hdfs oz command and corona 
works properly after this patch. My apologies for being so finicky, we are 
close to a merge and I would not want to any commit to cause a test failure.

plus, I have a very small nit: {{loadContainerMaps(containerMapping);}} Can we 
call this function right after initializeContainerMaps, that way we don't need 
to even modify the initilizeContainerMaps. You can even rename the 
{{loadContainerMaps}} to {{loadExisitingContainers}}.




was (Author: anu):
bq. The listContainer json output changes after the patch as now the function 
outputs a list of ContainerInfo instead of list of Pipelines. Therefore the 
json now contains field from ContainerInfo class as well. 

care to post a sample of how these changes look like?Is there any benefit for 
the end-user due to this change?
 

> Ozone: SCM should read all Container info into memory when booting up
> ---------------------------------------------------------------------
>
>                 Key: HDFS-12521
>                 URL: https://issues.apache.org/jira/browse/HDFS-12521
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Anu Engineer
>            Assignee: Lokesh Jain
>              Labels: ozoneMerge
>         Attachments: HDFS-12521-HDFS-7240.001.patch, 
> HDFS-12521-HDFS-7240.002.patch, HDFS-12521-HDFS-7240.003.patch, 
> HDFS-12521-HDFS-7240.004.patch, HDFS-12521-HDFS-7240.005.patch
>
>
> When SCM boots up it should read all containers into memory. This is a 
> performance optimization that allows delays on SCM side. This JIRA tracks 
> that issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to