[
https://issues.apache.org/jira/browse/HDFS-12678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219422#comment-16219422
]
Nanda kumar commented on HDFS-12678:
------------------------------------
[~ljain], thanks for working on this. Overall the patch looks good to me, some
minor comments.
Corona.java
line:519 The value {{11}} will give us 11 quantile cutpoints, not 10.
line:514, 519 It's better to define a constant int variable and use it.
This one is not exactly related to this patch:
If we pass {{-numOfThreads}} as 100 and {{-numOfVolumes}} as 5, we actually run
only 5 threads. But while calculating the average time we use 100 which is
wrong.
We can add the following logic and use {{threadPoolSize}} while calculating
average instead of {{threadCount}} inside {{Corona#printStats}}
{code:title=Corona#run}
int threadCount = Integer.parseInt(numOfThreads);
int volumeCount = Integer.parseInt(numOfVolumes);
threadPoolSize = threadCount < volumeCount ? threadCount : volumeCount;
processor = Executors.newFixedThreadPool(threadPoolSize);
{code}
> Ozone: Corona: Add statistical information to json output
> ---------------------------------------------------------
>
> Key: HDFS-12678
> URL: https://issues.apache.org/jira/browse/HDFS-12678
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Attachments: HDFS-12678-HDFS-7240.001.patch,
> HDFS-12678-HDFS-7240.002.patch
>
>
> The Corona json output should contain statistical information like mean,
> quantiles and standard deviation of time taken by ozone operations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
