[
https://issues.apache.org/jira/browse/HDFS-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044974#comment-13044974
]
Hadoop QA commented on HDFS-1619:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481591/HDFS-1619-C99.patch.txt
against trunk revision 1132698.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/719//console
This message is automatically generated.
> Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T,
> AC_TYPE_INT64_T and AC_TYPE_UINT16_T ?
> --------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1619
> URL: https://issues.apache.org/jira/browse/HDFS-1619
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Roman Shaposhnik
> Assignee: Konstantin Shvachko
> Attachments: HDFS-1619-C99.patch.txt, HDFS-1619.patch.txt,
> hdfs-1619-2.patch
>
>
> Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T
> and AC_TYPE_UINT16_T and thus requires autoconf 2.61 or higher.
> This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given
> that those are pretty popular and also given that it is really difficult to
> find a platform
> these days that doesn't natively define intXX_t types I'm curious as to
> whether we can simply remove those macros or perhaps fail ONLY if we happen
> to be on such
> a platform.
> Here's a link to GNU autoconf docs for your reference:
> http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
