[
https://issues.apache.org/jira/browse/HDFS-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225022#comment-16225022
]
Mukul Kumar Singh commented on HDFS-12720:
------------------------------------------
Thanks for the review [~nandakumar131].
HDFS-12745 has been raised to handle pending review comments.
[~anu] & [~szetszwo] Please have a look at this patch.
ContainerStateManager.java
line 413: Is there any reason for this change?
bq. I realized that container state wasn't changed correctly when the container
was being marked as closed. This change will just ensure that we are not
iterating over closed containers unnecessarily.
RatisManagerImpl.java
line 41: Unused import
bq. Done.
line 131: Why are we constructing a new pipeline objects? Can't we use the same
object returned by findOpenPipeline(replicationFactor)
bq. This is needed as The dispatcher code in the Datanode still expects the
container name to be set in the Pipeline Info. A new pipeline is allocated so
that a new container name can be passed. This code will be streamlined as part
of HDFS-12745. Current patch will just ensure that ratis starts working asap.
Is there any reason for moving the below code from allocateRatisPipeline to
getPipeline?
// Start all pipeline names with "Ratis", easy to grep the logs.
String pipelineName = PREFIX +
UUID.randomUUID().toString().substring(PREFIX.length());
bq. Done. Removed
RpcClient.java
I understand the reason for having verifyRatisReplication, we can change it to
getKsmKeyInfo and do the actual verification in the test case.
bq. Thanks for the suggestion. Done.
The following is not related to this patch:
Do we need container name in Pipeline?
A single pipeline can be used by more than one container, in that case, it
doesn't make sense to have container name in the pipeline.
bq. This will be handled as part of HDFS-12745.
> Ozone: Ratis options are not passed from KSM Client protobuf helper correctly.
> ------------------------------------------------------------------------------
>
> Key: HDFS-12720
> URL: https://issues.apache.org/jira/browse/HDFS-12720
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Labels: ozoneMerge
> Fix For: HDFS-7240
>
> Attachments: HDFS-12720-HDFS-7240.001.patch,
> HDFS-12720-HDFS-7240.002.patch, HDFS-12720-HDFS-7240.003.patch
>
>
> {{KeySpaceManagerProtocolClientSideTranslatorPB#allocateBlock}} and
> {{KeySpaceManagerProtocolClientSideTranslatorPB#openKey}} do not pass the
> ratis replication factor and replication type to the KSM server. this causes
> the allocations using ratis model to resort to standalone mode even when
> Ratis mode is specified.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
